[PATCH] D118549: apply two more cases for store combine

[Baoshan Pang via Phabricator via llvm-commits]

BaoshanPang marked 4 inline comments as done.
BaoshanPang added inline comments.
Herald added a project: All.


================
Comment at: llvm/test/CodeGen/RISCV/store-combine.ll:79
+
+!4 = !{!5, !6, i64 0}
+!5 = !{!"ab", !6, i64 0, !6, i64 1, !6, i64 2, !6, i64 3}
----------------
jrtc27 wrote:
> BaoshanPang wrote:
> > frasercrmck wrote:
> > > Do we need all of this metadata for the test to work? I presume we don't need TBAA since the stores trivially don't alias.
> > I am not sure how to remove TBAA(!7). 
> > !7 is referenced by !6, i6 is referenced by all other variables. If I remove !7, it seems I will need to remove all other variables.
> But are //any// of them needed?
Yes, they are not needed. I fixed them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118549/new/

https://reviews.llvm.org/D118549