[PATCH] D6407: [InstCombine] Minor optimization for bswap with binary ops

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 5 14:33:58 PST 2022


xbolva00 added a comment.

In D6407#3362013 <https://reviews.llvm.org/D6407#3362013>, @deeprobin wrote:

> @RKSimon
>
> Do you have an example in which productive case this optimization is useful?
> No developer will intentionally create two bswaps in a row.
>
> Or was this PR just a nice-to-have?
>
> /cc @qcolombet 
> /cc @EgorBo

Example code in PR:

https://bugs.llvm.org/show_bug.cgi?id=15782

8 year old patch…

>> No developer will …

Very strong words :D

In D6407#3362013 <https://reviews.llvm.org/D6407#3362013>, @deeprobin wrote:

> @RKSimon
>
> Do you have an example in which productive case this optimization is useful?
> No developer will intentionally create two bswaps in a row.
>
> Or was this PR just a nice-to-have?
>
> /cc @qcolombet 
> /cc @EgorBo




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D6407/new/

https://reviews.llvm.org/D6407



More information about the llvm-commits mailing list