[PATCH] D120993: [PassManager] Add pretty stack entries before P->run() call.

Sat Mar 5 13:06:16 PST 2022

aeubanks added a comment.

Definitely seems good.
This  should be added for all adaptors (module->cgscc,module->function,cgscc->function,function->loop) and pass managers (loop/cgscc are implemented separately)
PassManager.h/cpp, LoopPassManager.h/cpp, CGSCCPassManager.h/cpp

Could be tested with the crash pass that was supposed to be landed in https://reviews.llvm.org/D86657, which needs to be relanded

================
Comment at: llvm/lib/IR/PassManager.cpp:177-180
+  else if (isa<BasicBlock>(V))
+    OS << "basic block";
+  else
+    OS << "value";
----------------
We'll either have a Loop, Function, SCC, or Module (MachineFunction doesn't work yet, but I guess it doesn't hurt to add)
See StandardInstrumentations.cpp for similar code

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120993/new/

https://reviews.llvm.org/D120993