[PATCH] D118642: [IVDescriptor] Find original 'Previous' for first-order recurrences.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 5 11:50:18 PST 2022


fhahn marked an inline comment as done.
fhahn added a comment.

In D118642#3361598 <https://reviews.llvm.org/D118642#3361598>, @dyung wrote:

> @fhahn This change seems to be hitting an assertion failure in one of our internal tests. I have filed GHI#54223 <https://github.com/llvm/llvm-project/issues/54223> with a repro. Can you take a look?

Thanks, that should be fixed by de8ac485e5b7 <https://reviews.llvm.org/rGde8ac485e5b76cc48c396a0748499277690d1012>

The issue was that the order in the map vector wasn't correct. That has been fixed by remove the entry before re-sinking. This ensures it will be sunk after all earlier instructions have been sunk.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118642/new/

https://reviews.llvm.org/D118642



More information about the llvm-commits mailing list