[PATCH] D121033: [cmake] Pass /winsysroot explicitly

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 17:12:04 PST 2022


smeenai created this revision.
smeenai added reviewers: ychen, thakis, mstorsjo.
Herald added a subscriber: mgorny.
Herald added a project: All.
smeenai requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We were relying on HandleLLVMOptions adding this flag, but that's not
included in compiler-rt. Add the flag explicitly ourselves to ensure
it's present; the duplication of the flag in the parts of the build
which do include HandleLLVMOptions doesn't cause any issues.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121033

Files:
  llvm/cmake/platforms/WinMsvc.cmake


Index: llvm/cmake/platforms/WinMsvc.cmake
===================================================================
--- llvm/cmake/platforms/WinMsvc.cmake
+++ llvm/cmake/platforms/WinMsvc.cmake
@@ -265,6 +265,7 @@
     --target=${TRIPLE_ARCH}-windows-msvc
     -fms-compatibility-version=19.20
     -vctoolsversion ${MSVC_VER}
+    -winsysroot ${LLVM_WINSYSROOT}
     -winsdkversion ${WINSDK_VER})
 
 if(case_sensitive_filesystem)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121033.413171.patch
Type: text/x-patch
Size: 425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220305/a2ac1726/attachment.bin>


More information about the llvm-commits mailing list