[PATCH] D120781: [IRLinker] materialize Functions before moving any

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 16:33:40 PST 2022


nickdesaulniers added a comment.

In D120781#3361107 <https://reviews.llvm.org/D120781#3361107>, @dexonsmith wrote:

> Result of linking a.ll and b.ll looks to me like it produces a bogus `blockaddress`:

That's weird, but note that that case does not lazily add to the running worklist.  `available_externally` linkage seems to, but test cases like mine but marked `available_externally` already seem to work regardless of my patch (and I'm happy to add tests for that to prove that).

Otherwise I don't think we've found a concrete test case for which my approach does not work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120781/new/

https://reviews.llvm.org/D120781



More information about the llvm-commits mailing list