[PATCH] D120177: [BOLT] CMOVConversion pass

Fri Mar 4 15:27:11 PST 2022

Amir marked 2 inline comments as done.
Amir added inline comments.

================
Comment at: bolt/include/bolt/Passes/CMOVConversion.h:40
+  /// Record how many possible cases there are.
+  uint64_t PossibleConversions = 0;
+
----------------
rafauler wrote:
> Can we also record instruction frequency and come up with a dynamic metric such as "out of 10000 executed instructions that could be converted to cmov, we converted 5000 (50%)"?
Changed reporting into the following:
  BOLT-INFO: CMOVConversion: test_memoperand_loop, converted static 0/1 (0.00%) hammock(s) into CMOV sequences, with dynamic execution count 0/2 (0.00%), saving 0/2 (0.00%) mispredictions
  BOLT-INFO: CMOVConversion total: converted static 0/6 (0.00%) hammock(s) into CMOV sequences, with dynamic execution count 0/12 (0.00%), saving 0/12 (0.00%) mispredictions

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120177/new/

https://reviews.llvm.org/D120177