[PATCH] D120622: [AArch64] Use correct calling convention for each vararg

[Le Philousophe via Phabricator via llvm-commits]

lephilousophe added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/darwinpcs-musttail.ll:17
+  ret void
+}
----------------
efriedma wrote:
> lephilousophe wrote:
> > efriedma wrote:
> > > Can you add a plain "tail" testcase in addition to the "musttail" testcase, since this patch affects the behavior of that too?
> > I don't see how ot do this test as tail calls don't support ellipses at the end to call back varargs.
> `tail call void (%class.C*, i8*, ...) @_ZN1C3addEPKcz(%class.C* noundef nonnull align 8 dereferenceable(28) undef, i8* noundef %1)` should trigger the relevant codepath, I think?
Indeed. Thanks!
I renamed the file name in the same time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120622/new/

https://reviews.llvm.org/D120622