[PATCH] D120938: [lld-macho][nfc] Rename some tests for consistency

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 11:23:35 PST 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rG984197612ce9: [lld-macho][nfc] Rename some tests for consistency (authored by int3).

Changed prior to commit:
  https://reviews.llvm.org/D120938?vs=412834&id=413080#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120938/new/

https://reviews.llvm.org/D120938

Files:
  lld/test/MachO/archive-symbol-resolution.s
  lld/test/MachO/resolution.s
  lld/test/MachO/symbol-order.s
  lld/test/MachO/symbol-resolution.s


Index: lld/test/MachO/archive-symbol-resolution.s
===================================================================
--- lld/test/MachO/archive-symbol-resolution.s
+++ lld/test/MachO/archive-symbol-resolution.s
@@ -10,6 +10,8 @@
 # RUN: llvm-ar rcs %t/libf2_g.a %t/f2.o %t/g.o
 # RUN: llvm-ar rcs %t/libfg.a %t/fg.o
 
+## (Strong) dylib symbols and archive symbols have equal precedence.
+
 # RUN: %lld %t/libf1.dylib %t/libf2_g.a %t/test.o -o %t/test.out -lSystem
 # RUN: llvm-objdump --syms --macho --lazy-bind %t/test.out | FileCheck %s --check-prefix DYLIB-FIRST
 # DYLIB-FIRST:      SYMBOL TABLE:
@@ -27,6 +29,8 @@
 # ARCHIVE-FIRST-NEXT: segment  section            address       dylib            symbol
 # ARCHIVE-FIRST-EMPTY:
 
+## Once an archive member is fetched, all the extern symbols in that member
+## take precedence over dylib symbols of the same name.
 # RUN: %lld %t/libf1.dylib %t/libfg.a %t/test.o -o %t/test.out -lSystem
 # RUN: llvm-objdump --syms --macho --lazy-bind %t/test.out | FileCheck %s --check-prefix ARCHIVE-PRIORITY
 # ARCHIVE-PRIORITY:      SYMBOL TABLE:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120938.413080.patch
Type: text/x-patch
Size: 1090 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220304/fa7c2bde/attachment.bin>


More information about the llvm-commits mailing list