[lld] 72c5b26 - [lld-macho][nfc] Use %X in mapfile test
Jez Ng via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 4 11:23:26 PST 2022
Author: Jez Ng
Date: 2022-03-04T14:21:17-05:00
New Revision: 72c5b26f3d6502fc64ae78923c92ef57f7e971c4
URL: https://github.com/llvm/llvm-project/commit/72c5b26f3d6502fc64ae78923c92ef57f7e971c4
DIFF: https://github.com/llvm/llvm-project/commit/72c5b26f3d6502fc64ae78923c92ef57f7e971c4.diff
LOG: [lld-macho][nfc] Use %X in mapfile test
LLD (and ld64) emits uppercase hex addresses in the mapfile. The
map-file.s test passes right now because the addresses we emit happen
not to include any alphabets, but that can easily change.
I noticed this while dealing with
https://github.com/llvm/llvm-project/issues/54184.
Reviewed By: #lld-macho, thakis
Differential Revision: https://reviews.llvm.org/D120941
Added:
Modified:
lld/test/MachO/map-file.s
Removed:
################################################################################
diff --git a/lld/test/MachO/map-file.s b/lld/test/MachO/map-file.s
index 11ad7f0079cc2..8b0585768905a 100644
--- a/lld/test/MachO/map-file.s
+++ b/lld/test/MachO/map-file.s
@@ -30,16 +30,16 @@
# CHECK-NEXT: [ 2] {{.*}}{{/|\\}}map-file.s.tmp/foo.o
# CHECK-NEXT: # Sections:
-# CHECK-NEXT: # Address Size Segment Section
-# CHECK-NEXT: 0x[[#TEXT]] 0x{{[0-9a-f]+}} __TEXT __text
-# CHECK-NEXT: 0x[[#DATA]] 0x{{[0-9a-f]+}} __TEXT obj
-# CHECK-NEXT: 0x[[#BSS]] 0x{{[0-9a-f]+}} __DATA __common
+# CHECK-NEXT: # Address Size Segment Section
+# CHECK-NEXT: 0x[[#%X,TEXT]] 0x{{[0-9a-f]+}} __TEXT __text
+# CHECK-NEXT: 0x[[#%X,DATA]] 0x{{[0-9a-f]+}} __TEXT obj
+# CHECK-NEXT: 0x[[#%X,BSS]] 0x{{[0-9a-f]+}} __DATA __common
# CHECK-NEXT: # Symbols:
-# CHECK-NEXT: # Address File Name
-# CHECK-NEXT: 0x[[#MAIN]] [ 1] _main
-# CHECK-NEXT: 0x[[#FOO]] [ 2] _foo
-# CHECK-NEXT: 0x[[#NUMBER]] [ 1] _number
+# CHECK-NEXT: # Address File Name
+# CHECK-NEXT: 0x[[#%X,MAIN]] [ 1] _main
+# CHECK-NEXT: 0x[[#%X,FOO]] [ 2] _foo
+# CHECK-NEXT: 0x[[#%X,NUMBER]] [ 1] _number
# RUN: %lld -map %t/c-string-literal-map %t/c-string-literal.o -o %t/c-string-literal-out
# RUN: FileCheck --check-prefix=CSTRING %s < %t/c-string-literal-map
More information about the llvm-commits
mailing list