[compiler-rt] 9c35303 - [InstrProf][NFC] Fix warning by removing typecast

Ellis Hoag via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 10:48:30 PST 2022


Author: Ellis Hoag
Date: 2022-03-04T10:48:25-08:00
New Revision: 9c35303981ae9a4495b3590fca9c3afbf34af213

URL: https://github.com/llvm/llvm-project/commit/9c35303981ae9a4495b3590fca9c3afbf34af213
DIFF: https://github.com/llvm/llvm-project/commit/9c35303981ae9a4495b3590fca9c3afbf34af213.diff

LOG: [InstrProf][NFC] Fix warning by removing typecast

This fixes a warning about comparing mismatched types. Since `mmap()` already returns a `void *` use that as the pointer type for comparison.

Reviewed By: kyulee, zequanwu

Differential Revision: https://reviews.llvm.org/D120945

Added: 
    

Modified: 
    compiler-rt/lib/profile/InstrProfilingFile.c

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/profile/InstrProfilingFile.c b/compiler-rt/lib/profile/InstrProfilingFile.c
index 363ded9554ce3..81aa2c03c9e55 100644
--- a/compiler-rt/lib/profile/InstrProfilingFile.c
+++ b/compiler-rt/lib/profile/InstrProfilingFile.c
@@ -141,9 +141,9 @@ static int mmapForContinuousMode(uint64_t CurrentFileOffset, FILE *File) {
   uint64_t FileOffsetToCounters = CurrentFileOffset +
                                   sizeof(__llvm_profile_header) + DataSize +
                                   PaddingBytesBeforeCounters;
-  uint64_t *CounterMmap = (uint64_t *)mmap(
-      (void *)CountersBegin, PageAlignedCountersLength, PROT_READ | PROT_WRITE,
-      MAP_FIXED | MAP_SHARED, Fileno, FileOffsetToCounters);
+  void *CounterMmap = mmap((void *)CountersBegin, PageAlignedCountersLength,
+                           PROT_READ | PROT_WRITE, MAP_FIXED | MAP_SHARED,
+                           Fileno, FileOffsetToCounters);
   if (CounterMmap != CountersBegin) {
     PROF_ERR(
         "Continuous counter sync mode is enabled, but mmap() failed (%s).\n"


        


More information about the llvm-commits mailing list