[PATCH] D112330: [AArch64] Async unwind - function epilogues

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 08:28:41 PST 2022


chill added a comment.

Committing this change caused failures in the asan/hwasan regression tests. The reason was that emitting unwind info
in epilogues caused the unwind information in case like below:

  foo:
    ...
    CSR saves
    ...
    CSR restores
    ret
  L:
    ...
    b <somewhere>

to no longer be accidentally correct for the region starting at `L`. That could be a miscompilation
if a throwing call somehow ends up in that region.

Thus, I've changed the order of the patches to bring CFIFixup  before the this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112330/new/

https://reviews.llvm.org/D112330



More information about the llvm-commits mailing list