[PATCH] D120994: [Coroutines] Allow FramePtr to be an Argument

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 06:17:40 PST 2022


nikic created this revision.
nikic added reviewers: ChuanqiXu, lxfind, opaque-pointers.
Herald added a subscriber: hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

With opaque pointers, after splitRetconCoroutine() the FramePtr may be an Argument rather than an Instruction. With typed pointers, this currently doesn't happen because the FramePtr would be a bitcast instruction.

Fix this by making FramePtr a Value and adding a helper for the "after FramePtr" insertion pointer, which would be the start of the function in the Argument case.


https://reviews.llvm.org/D120994

Files:
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp
  llvm/lib/Transforms/Coroutines/CoroInternal.h
  llvm/lib/Transforms/Coroutines/CoroSplit.cpp
  llvm/test/Transforms/Coroutines/coro-retcon-opaque-ptr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120994.412992.patch
Type: text/x-patch
Size: 9000 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220304/485aa910/attachment.bin>


More information about the llvm-commits mailing list