[PATCH] D120988: [CoroElide] Remove fallback for frame layout determination

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 04:13:13 PST 2022


nikic created this revision.
nikic added reviewers: ChuanqiXu, lxfind, opaque-pointers.
Herald added a subscriber: hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Only determine the frame layout based on dereferenceable and align attributes, and remove the type-based fallback, which is incompatible with opaque pointers. The dereferenceable attribute is required, while the align attribute uses default alignment of 1 (usually, `align 1` attributes do not get placed, relying on default alignment).

The clang-side integration test for this optimization passes, so the frontend does add the necessary attributes.


https://reviews.llvm.org/D120988

Files:
  llvm/lib/Transforms/Coroutines/CoroElide.cpp
  llvm/test/Transforms/Coroutines/coro-elide-musttail.ll
  llvm/test/Transforms/Coroutines/coro-elide-stat.ll
  llvm/test/Transforms/Coroutines/coro-elide.ll
  llvm/test/Transforms/Coroutines/coro-heap-elide.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120988.412980.patch
Type: text/x-patch
Size: 4646 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220304/549ca300/attachment.bin>


More information about the llvm-commits mailing list