[PATCH] D120987: [Attributor] Remove restriction on simplifying function pointers

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
Herald added subscribers: ormris, okura, jdoerfert, kuter, uenoku, hiraditya.
Herald added a reviewer: uenoku.
Herald added a reviewer: homerdin.
Herald added a project: All.
nikic requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: sstefan1.
Herald added a reviewer: baziotis.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Dropping this restriction seems to work fine (there are no assertion failures), but I'm not sure whether this is guarding against some kind of silent CG corruption.

If doing this is still problematic, then the place to address it would probably be https://github.com/llvm/llvm-project/blob/8f5bdaf481c3f4e6876a5ae0e4d7c6ed2042e6a6/llvm/lib/Transforms/IPO/Attributor.cpp#L1856-L1859, which already prevents replacement outside the SCC, so I'm not quite sure what this check is intended to avoid.


https://reviews.llvm.org/D120987

Files:
  llvm/lib/Transforms/IPO/AttributorAttributes.cpp
  llvm/test/Transforms/Attributor/liveness.ll
  llvm/test/Transforms/Attributor/value-simplify.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120987.412972.patch
Type: text/x-patch
Size: 7852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220304/c8901119/attachment.bin>