[PATCH] D116879: [llvm] Allow auto-vectorization of sincos() using libmvec

[Tim Schmielau via Phabricator via llvm-commits]

tim.schmielau added a comment.
Herald added a project: All.

I have just submitted the test for the testsuite <https://reviews.llvm.org/D120977>. Once that is merged, this change should also be fine to go in.

> And a variant of the code above shows that even the transformation to the `vvv` variant isn't safe in all cases.

I must have made a mistake there, as I cannot reproduce the failure anymore.

> I'm assuming you need the pragmas to force vectorisation in your tests.

The pragma is only for convenience to shorten the loop body for manual inspection. It has no other impact on the result.

> We usually don't merge other people's patches unless they ask for it (like those that don't have commit permissions), so we should be safe.

I just wanted to be explicit, as further up I had already requested merging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116879/new/

https://reviews.llvm.org/D116879