[PATCH] D120641: [RISCV] Add codegen for vp.fptosi.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3684
+  case ISD::VP_FPTOSI:
+    return lowerVPOp(Op, DAG, RISCVISD::FP_TO_SINT_VL);
   }
----------------
craig.topper wrote:
> This doesn't work if the int and FP types don't have the same element size. FP_TO_SINT_VL does not guarantee this. See the lowering for ISD::FP_TO_SINT which has to handle widening, narrowing, and multi instruction cases.
Done, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120641/new/

https://reviews.llvm.org/D120641