[PATCH] D120544: [AMDGPU] Omit unnecessary waitcnt before barriers

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 22:42:44 PST 2022


kerbowa updated this revision to Diff 412935.
kerbowa marked an inline comment as done.
kerbowa added a comment.
Herald added a project: All.

Update test to use -mattr.

Forgot that there is a bug (feature?) where disabling a feature that
is in a "SubtargetFeatureGeneration" class disables ALL of the
features in that definition. Add BackOffBarrier to each gfx10
definition individually so that I can use -mattr in the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120544/new/

https://reviews.llvm.org/D120544

Files:
  llvm/lib/Target/AMDGPU/AMDGPU.td
  llvm/lib/Target/AMDGPU/GCNSubtarget.h
  llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
  llvm/test/CodeGen/AMDGPU/back-off-barrier-subtarget-feature.ll
  llvm/test/CodeGen/AMDGPU/waitcnt-preexisting-vscnt.mir
  llvm/test/CodeGen/AMDGPU/waitcnt-vscnt.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120544.412935.patch
Type: text/x-patch
Size: 11436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220304/bc48ccc3/attachment.bin>


More information about the llvm-commits mailing list