[PATCH] D119899: [TableGen] Add a library-based entry point for parsing td files

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 21:28:25 PST 2022


rriddle added a comment.

In D119899#3359094 <https://reviews.llvm.org/D119899#3359094>, @dblaikie wrote:

> The unit test was failing for me (in the cmake and bazel builds) due to other files already being present in the SrcMgr - so I tried this patch: d60a65abb6b050e10d9efdbc56dcb2e2e4772af1 <https://reviews.llvm.org/rGd60a65abb6b050e10d9efdbc56dcb2e2e4772af1> to address that. No idea if it's right/good, but I guess if this function can reset the SrcMgr at the end, it's probably OK to reset it at the start too?

Weird. That fix looks appropriate to me, thanks for submitting it! Realistically we should be able to reset at the start, we can just plumb any initialization of the SrcMgr (e.g. diag handler) as params to this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119899/new/

https://reviews.llvm.org/D119899



More information about the llvm-commits mailing list