[PATCH] D120926: [Mips] support "sp" named register

Thu Mar 3 13:40:58 PST 2022

nickdesaulniers added a comment.

In D120926#3358183 <https://reviews.llvm.org/D120926#3358183>, @atanasyan wrote:

> Do you have commit access?

Yep.

In D120926#3358178 <https://reviews.llvm.org/D120926#3358178>, @nathanchance wrote:

> I can build `malta_defconfig` on `next-20220303` with this patch. I enabled `CONFIG_DEBUG_STACKOVERFLOW` and `CONFIG_HARDENED_USERCOPY`, which both use `current_stack_pointer`, and did not see any warnings/errors.

I appreciate it!

================
Comment at: llvm/test/CodeGen/Mips/named-register-n64.ll:26
 !llvm.named.register.$28 = !{!0}
+!llvm.named.register.$28 = !{!1}

----------------
nathanchance wrote:
> Should this be `!llvm.named.register.$sp = !{!1}`?
Yes; good catch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120926/new/

https://reviews.llvm.org/D120926