[PATCH] D119475: [AMDGPU] Add scheduler pass to rematerialize trivial defs

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 10:42:26 PST 2022


rampitec added a comment.

Does it pass PSDB?



================
Comment at: llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp:425
+      RegionsWithMinOcc[RegionIdx] =
+          PressureAfter.getOccupancy(ST) == MinOccupancy ? true : false;
       if (!RegionsWithClusters[RegionIdx] &&
----------------
Just `= PressureAfter.getOccupancy(ST) == MinOccupancy;`


================
Comment at: llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp:436
+  RegionsWithMinOcc[RegionIdx] =
+      PressureBefore.getOccupancy(ST) == MinOccupancy ? true : false;
   LLVM_DEBUG(dbgs() << "Attempting to revert scheduling.\n");
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119475/new/

https://reviews.llvm.org/D119475



More information about the llvm-commits mailing list