[PATCH] D120000: [1/2] TLS loads opimization (hoist)
Nuno Lopes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 3 10:21:40 PST 2022
nlopes added a comment.
In D120000#3357413 <https://reviews.llvm.org/D120000#3357413>, @craig.topper wrote:
>> Anyway, this transformation works by creating some artificial bitcasts that you expect to be carried over to the backend so the lowering can share the calls to the TLS function.
>>
>> This strategy seems very brittle to me. If some later optimization decides to remove the bitcast, your optimization will stop working. It's very likely that will be the case once opaque pointers take over.
>
> Is this much different than the artificial bitcast we use in ConstantHoisting?
Didn't know there was a precedent of using this technique. Seems fragile to me, but...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120000/new/
https://reviews.llvm.org/D120000
More information about the llvm-commits
mailing list