[PATCH] D113520: [SROA] Maintain shadow/backing alloca when some slices are noncapturnig read-only calls to allow alloca partitioning/promotion

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 06:48:42 PST 2022


lebedev.ri added a comment.

In D113520#3357128 <https://reviews.llvm.org/D113520#3357128>, @djtodoro wrote:

> LGTM for my side, but please wait a few days to see if someone has some additional comments (although it looks like all the comments are already addressed).

Thank you!

I'm hoping @reames would find time to re-review this, but given that
we've settled on the approach, and it's rather straight-forward,
i don't know how long i should wait indeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113520/new/

https://reviews.llvm.org/D113520



More information about the llvm-commits mailing list