[PATCH] D120800: [MachineSink] Disable if there are any irreducible cycles

Thu Mar 3 05:30:41 PST 2022

shchenz added a comment.

My initial thought is to bail out only if the loop containing `MBB` or `SuccToSinkTo` in `isProfitableToSinkTo` contains irreducible cfg or not. I guess we checked the whole function instead of the single loop because `LoopBlocksRPO`(which is suitable to check a single loop) does not have a MachineLoop version?

I plan to do this based on MachineCycleInfo for the main branch, But I need more time. If this code size issue caused by this approach is some kind of seriousness and urgent, yes, I am also OK to use the alternatives, D120330 <https://reviews.llvm.org/D120330>, or revert D86864 <https://reviews.llvm.org/D86864>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120800/new/

https://reviews.llvm.org/D120800