[PATCH] D120754: [InstCombine][Analysis] Move getFCmpCode and getPredForFCmpCode to CmpInstAnalysis. NFC
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 3 02:11:21 PST 2022
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.
LGTM - with one minor formatting query
================
Comment at: llvm/include/llvm/Analysis/CmpInstAnalysis.h:67
+ // Take advantage of the bit pattern of CmpInst::Predicate here.
+ // U L G E
+ static_assert(CmpInst::FCMP_FALSE == 0, ""); // 0 0 0 0
----------------
Has the indentation been altered for the ULGE column headers or is it just phab?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120754/new/
https://reviews.llvm.org/D120754
More information about the llvm-commits
mailing list