[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

ShihPo Hung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 02:02:28 PST 2022


arcbbb added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4683
+    Ops.push_back(VL);
+    Ops.push_back(DAG.getUNDEF(XLenVT)); // Policy
+  }
----------------
kito-cheng wrote:
> Is this operand for tail policy? if so why this is `UNDEF`? I guess this should be `TAIL_AGNOSTIC` rather than `UNDEF`?
Because unmasked pseudos doesn't have a policy operand,
TA/TU is distinguished by checking if passthru is undef. I think it is proper to leave undef here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120449/new/

https://reviews.llvm.org/D120449



More information about the llvm-commits mailing list