[PATCH] D119900: [PDLL] Add support for tablegen includes and importing ODS information

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 23:53:05 PST 2022


rriddle added a comment.

In D119900#3356279 <https://reviews.llvm.org/D119900#3356279>, @nicolasvasilache wrote:

> @rriddle could you land your stack?

Yep, sorry for the delay. Now that Jacques reviewed, PDL(L) is back at the top of my stack, so I'll be going through things tomorrow (PST).

> Also, what do you expect the support to look like for something like `class RankedFloatElementsAttr<int width, list<int> dims> :` ?
> Is the idea that pdll will understand `int` as a first class citizen or that we'll go through e.g. `I64`? 
> What about `list<int>` ?

For tablegen import, we can only really import defs at this point; i.e., we won't be able to import templated classes. So for now, if we want to
use them we'll generally need to explicitly define the templates we care about in .td and then import the fully specialized def.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119900/new/

https://reviews.llvm.org/D119900



More information about the llvm-commits mailing list