[PATCH] D120731: [llvm] add -o flag to llvm-bitcode-strip

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 22:36:15 PST 2022


jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:1214
+        errc::invalid_argument,
+        "llvm-bitcode-strip expects a single output path specified with -o");
+  }
----------------
I'd change this comment: the error message already has `llvm-bitcode-strip` in the prefix, so no need to repeat it in the body of the message. Perhaps simply "-o is a required argument" (alternative ideas also welcome)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120731/new/

https://reviews.llvm.org/D120731



More information about the llvm-commits mailing list