[PATCH] D120855: [AMDGPU] gfx940 uses new names for coherency bits

[Carl Ritson via Phabricator via llvm-commits]

critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4263
 
-  if (isGFX90A() && (CPol & CPol::SCC)) {
+  if (isGFX90A() && !isGFX940() && (CPol & CPol::SCC)) {
     SMLoc S = getImmLoc(AMDGPUOperand::ImmTyCPol, Operands);
----------------
This code looks odd because from the naming alone I would expect isGFX90A and isGFX940 to be mutually exclusive.
Should those test really be named hasGFX90A_Insts, or be actually made exclusive?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120855/new/

https://reviews.llvm.org/D120855