[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

[ChenZheng via Phabricator via llvm-commits]

shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.

LGTM. Two nits about the comments and tests.

Please wait for some days in case other reviews have some comments.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15196
                                            const CallExpr *E) {
+  // __builtin_ppc_fnmsub, __builtin_ppc_fnmsubs
   SmallVector<Value*, 4> Ops;
----------------
why add this comment here?


================
Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-math.c:98
 // CHECK-NEXT:    store double [[D:%.*]], double* [[D_ADDR]], align 8
+// CHECK-COUNT-3:    load double, double* [[D_ADDR]], align 8
 // CHECK-NEXT:    [[TMP0:%.*]] = load double, double* [[D_ADDR]], align 8
----------------
If we improve the check lines to CHECK-COUNT, do we still need the original CHECKs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116015/new/

https://reviews.llvm.org/D116015