[PATCH] D120622: [AArch64] Use correct calling convention for each vararg

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I kind of side tracked the review, sorry about that. What's the next step here? Is it worth taking the time to rewrite this logic to refactor it and divide the musttail-relevant checks from the regular checks, or should we go forward with improving this patch?

I think I don't like the complexity in this patch. Ideally, I would like to declare non-musttail vararg tail calls to be unsupported: we shouldn't have to forward variadic arguments between functions with mismatched prototypes. To me, that's what's adding a lot of complexity in the eligibility checks here. One of the major use cases for the musttail feature is to make it *possible * to forward variadic argument packs because we don't have to worry about moving around arguments that live in memory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120622/new/

https://reviews.llvm.org/D120622