[PATCH] D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 12:31:37 PST 2022


dblaikie added a comment.

Yeah, I'm not sure this is a great way to go - we do have info in the symbolizer for where the start of the function is, is that sufficient for the use cases you've come across?

And if we're going to give an approximate answer, it shouldn't be based on the probing solution implemented here - but probably lower-level/based on walking the line table to find the nearest non-zero location instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120660/new/

https://reviews.llvm.org/D120660



More information about the llvm-commits mailing list