[PATCH] D120173: [LTO] Initialize canAutoHide() using canBeOmittedFromSymbolTable()

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.

LGTM, thanks for fixing! One suggestion below for updating the test description. Also, can you update the patch description to note specifically what is changing as a result of the patch - i.e. that local_unnamed_addr constants can now also be auto hidden. The current summary mentions that the prior approach only handled linkonce_odr globals, which is still the case.



================
Comment at: llvm/test/ThinLTO/X86/linkonce_odr_unnamed_addr.ll:1
 ; This test ensures that when linkonce_odr + unnamed_addr symbols promoted to
 ; weak symbols, it preserves the auto hide property when possible.
----------------
Update comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120173/new/

https://reviews.llvm.org/D120173