[PATCH] D116220: [AIX][XCOFF] address post-commit review comments of patch https://reviews.llvm.org/D82549

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/aux-hdr-defaults.yaml:107
 # CASE2-NEXT:   Stack page size: 0x0
-# CASE2-NEXT:   Flag: 0x0
+# CASE2-NEXT:   Flag: 0x80
 # CASE2-NEXT:   Alignment of thread-local storage: 0x0
----------------
can you check why the yaml2obj  generate the flag 0x80 here ,not flag 0? @Esme 


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/basic-doc.yaml:49
 # CHECK-NEXT: }
+# CHECK-NEXT: AuxiliaryHeader {
+# CHECK-NEXT: }
----------------
according to comment https://reviews.llvm.org/D116220#inline-1115640, there will be empty  AuxiliaryHeader { } be printed out even if there no Auxiliary Header in an object file when we use "llvm-readobj  --headers".
what is your opinion ? @hubert.reinterpretcast  . at Esme 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116220/new/

https://reviews.llvm.org/D116220