[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

In D117887#3353653 <https://reviews.llvm.org/D117887#3353653>, @jchlanda wrote:

> I went with the web interface as described here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface 
> with `git diff -U999999 ...` didn't want to bite the bullet of `arc`, hoping that github PRs will soon be a thing.

`git show -U99999` should work even better as it would include author info and commit log message, so one would not need to re-enter it manually when importing the patch from phabricator.

In any case that's probably not the root cause of my error, just a minor inconvenience. 
I still have no idea what went wrong during my initial commit, but I think I've learned the lesson and will start double checking the imported changes for completeness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117887/new/

https://reviews.llvm.org/D117887