[PATCH] D120819: [flang] Handle module in lowering pass

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 09:12:41 PST 2022


PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Aside from the clang-format problem, all builds and tests correctly and looks good.



================
Comment at: flang/lib/Lower/Bridge.cpp:62-71
+    //  - Declare all functions that have definitions so that definition
+    //    signatures prevail over call site signatures.
+    //  - Define module variables and OpenMP/OpenACC declarative construct so
+    //    that they are available before lowering any function that may use
+    //    them.
     for (Fortran::lower::pft::Program::Units &u : pft.getUnits()) {
       std::visit(
----------------
With these changes, I'm getting differences after running clang-format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120819/new/

https://reviews.llvm.org/D120819



More information about the llvm-commits mailing list