[PATCH] D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR.

[Marius Brehler via Phabricator via llvm-commits]

marbre added a comment.

Thanks for working on this Stella! Untangling the functions/marcos is a bit hard. Thus, I am mainly commenting to make sure I fully understand the patch :)



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:821
+    $<BUILD_INTERFACE:${LLVM_INCLUDE_DIR}>
+  )
+
----------------
With your change to `llvm_add_library()` the generated objlib //can// propagate "public" includes, as `PUBLIC` in setting `INCLUDE_DIRECTORIES` and  `INTERFACE_INCLUDE_DIRECTORIES` (which looks good to me 👍).

Here, the public includes are added after the calling `llvm_add_library()`. A rapidly prototyped test script lets me assume that the order might important. Should the public includes be added before calling `llvm_add_library()` to mirror those?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120788/new/

https://reviews.llvm.org/D120788