[PATCH] D120669: [llvm] add -r functionality to llvm-bitcode-strip

Richard Howell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 07:26:50 PST 2022


rmaz added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/bitcode-strip.test:7-10
+## Test bitcode section removal
+
+# RUN: llvm-bitcode-strip -r %t -o %t2
+# RUN: llvm-readobj --sections %t2 | FileCheck %s
----------------
jhenderson wrote:
> Usually, we'd have one test file per option, i.e. in one test, you'd test -o, and another test, you'd test what the -r operation does.
The reason for using a single test is that you cannot use `-o` without `-r`, so all the `-o` test could do would be to test you get an error without `-r`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120669/new/

https://reviews.llvm.org/D120669



More information about the llvm-commits mailing list