[PATCH] D120753: [FuncSpec][NFC] Refactor internal structures.
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 2 01:44:42 PST 2022
SjoerdMeijer added a comment.
Herald added a project: All.
Looks like a good refactoring, but needs a clang-format, and have added one question inline.
================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:465
}
- return Worklist;
+ return WorkList;
}
----------------
Was wondering if we could change `SpecializationList` to:
SmallVector<std::unique_ptr<SpecializationInfo>>;
so that we move and transfer ownership instead of copying things here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120753/new/
https://reviews.llvm.org/D120753
More information about the llvm-commits
mailing list