[PATCH] D120000: [1/2] TLS loads opimization (hoist)

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added a comment.

I have some concerns with this patch:

- Why is it adding a new function attribute (tls-load-hoist) that is not documented in LangRef?
- Why can't this transformation be handled with existing optimizations? Adding e.g. the readonly & speculatable attributes should allow GVN & friends to remove duplicates and hoist these out of loops. If not, then maybe existing optimizations should be improved so others benefit as well.

In summary, do we really need this new pass or is this just a hack?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000