[PATCH] D120769: [AMDGPU] gfx940: support V_FMAMK_F32 and V_FMAAK_F32

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 00:57:19 PST 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:1747
+let SubtargetPredicate = HasFmaakFmamkF32Insts,
+    AssemblerPredicate = HasFmaakFmamkF32Insts in {
+defm V_FMAMK_F32        : VOP2_Real_MADK_gfx940 <0x17>;
----------------
Isn't AssemblerPredicate redundant if you've already set SubtargetPredicate? I thought they all got concatenated into one list of predicates.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120769/new/

https://reviews.llvm.org/D120769



More information about the llvm-commits mailing list