[PATCH] D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 2 00:43:49 PST 2022
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.
Updated patch is performance-neutral on our side. Based on some spot checks, it does resolve the catastrophic inlining issue as well. The general approach also looks reasonable.
================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:942
+ if (CalleeSCC != C &&
+ CalleeSCC == CG.lookupSCC(CG.get(*NewCallee))) {
+ ICB->addFnAttr(Attribute::NoInline);
----------------
Add a comment here for why the restriction exists.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120584/new/
https://reviews.llvm.org/D120584
More information about the llvm-commits
mailing list