[PATCH] D117694: [UpdateTestChecks] Add --filter and --filter-out options
Sebastian Neubauer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 2 00:30:39 PST 2022
sebastian-ne added a comment.
In D117694#3353315 <https://reviews.llvm.org/D117694#3353315>, @JOE1994 wrote:
> I see 6 non-temporal store instructions in `"llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-non-temporal.ll"`,
> but the expected output (`"llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-non-temporal.ll.filter.expected"`) checks for only 5 non-temporal instructions.
>
> Shouldn't the expected output check for 6 non-temporal stores instead of 5 ?
>
> Thank you
Yes, the first matched line is skipped. There’s a fix in D119704 <https://reviews.llvm.org/D119704>, but nobody felt inclined to review this yet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117694/new/
https://reviews.llvm.org/D117694
More information about the llvm-commits
mailing list