[PATCH] D120000: [1/2] TLS loads opimization (hoist)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/TLSVariableHoist.cpp:156
+
+static bool OneUseOutsideLoop(tlshoist::TLSCandidate &Cand, LoopInfo *LI) {
+  if (Cand.Users.size() != 1)
----------------
method names should be lowercase


================
Comment at: llvm/lib/Transforms/Scalar/TLSVariableHoist.cpp:198
+
+  BasicBlock *PreHeader = L->getLoopPredecessor();
+
----------------
Predecessor and PreHeader aren't quite the same thing. A PreHeader also has the loop as it's only successor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000