[PATCH] D118538: [SLP] Schedule only sub-graph of vectorizable instructions

Tue Mar 1 16:45:35 PST 2022

ABataev added a comment.

In D118538#3353157 <https://reviews.llvm.org/D118538#3353157>, @aeubanks wrote:

> Actually this sequence seems to pass check-llvm with expensive checks on. Is this reasonable?
> (only reverting the top two causes the test added in ee48b2f1c3f646a32557d21b7cf476466a8b8a2f to fail)
>
>   commit c0918b5685df34a1df56eaec9408b0053adce145 (HEAD)
>   Author: Arthur Eubanks <aeubanks at google.com>
>   Date:   Tue Mar 1 16:23:04 2022 -0800
>   
>       Revert "[SLP] Schedule only sub-graph of vectorizable instructions"
>       
>       This reverts commit 0539a26d91a1b7c74022fa9cf33bd7faca87544d.
>   
>   commit 97c3a3aea222b6cdc5972ebfa411a0f43ff45e7d
>   Author: Arthur Eubanks <aeubanks at google.com>
>   Date:   Tue Mar 1 16:22:59 2022 -0800
>   
>       Revert "[SLP] Remove SchedulingPriority from ScheduleData [NFC]"
>       
>       This reverts commit a3e9b32c00959ad5c73189d8378d019fbe80ade5.
>   
>   commit ee48b2f1c3f646a32557d21b7cf476466a8b8a2f
>   Author: Arthur Eubanks <aeubanks at google.com>
>   Date:   Tue Mar 1 16:21:43 2022 -0800
>   
>       Revert "[SLP][NFC]Add a test for bottom to top reordering."
>       
>       This reverts commit b3f4535a039918965adb21509700739afc25f9f1.
>   
>   commit b04a828ae3c19f5aa699f5e9821b04cb413bca9d
>   Author: Arthur Eubanks <aeubanks at google.com>
>   Date:   Tue Mar 1 16:21:38 2022 -0800
>   
>       Revert "[SLP]Improve bottom-to-top reordering."
>       
>       This reverts commit e4b9640867150723b33f81c6479682fc955b55aa.

Can you try to revert only this:

  commit c0918b5685df34a1df56eaec9408b0053adce145 (HEAD)
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   Tue Mar 1 16:23:04 2022 -0800

      Revert "[SLP] Schedule only sub-graph of vectorizable instructions"

      This reverts commit 0539a26d91a1b7c74022fa9cf33bd7faca87544d.

  commit 97c3a3aea222b6cdc5972ebfa411a0f43ff45e7d
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   Tue Mar 1 16:22:59 2022 -0800

      Revert "[SLP] Remove SchedulingPriority from ScheduleData [NFC]"

      This reverts commit a3e9b32c00959ad5c73189d8378d019fbe80ade5.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118538/new/

https://reviews.llvm.org/D118538