[PATCH] D120784: [CSSPGO][PriorityInliner] Do not use block weight to drive callsite inlining.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 16:21:34 PST 2022


wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1309
+  uint64_t CallsiteCount =
+      CalleeSamples ? CalleeSamples->getEntrySamples() * Factor : 0;
   *NewCandidate = {CB, CalleeSamples, CallsiteCount, Factor};
----------------
When we don't have callee samples, should we fall back to call site block counts? 

In reality we would also need to tolerate some source change, i.e. the call site didn't exist in pass1 build. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120784/new/

https://reviews.llvm.org/D120784



More information about the llvm-commits mailing list