[PATCH] D118088: [BOLT] Enable PLT analyzation for aarch64

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 added a subscriber: rafaelauler.
yota9 added a comment.

Hello @rafaelauler ! Thank you for your comments! Sorry for the long reply, something insane is going on I just don't have enough time and power these days :(



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:1258
 
+  uint64_t EntryOffset, InstrOffset = 0;
+  // Locate new plt entry
----------------
rafauler wrote:
> rafauler wrote:
> > EntryOffset is not a loop-carried dependency, better to declare it inside the loop.
> 
Agree, thanks


================
Comment at: bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp:747
+    SmallVector<MCInst *, 4> &UsesLdr = UDChain[Ldr];
+    if (UsesLdr.size() == 0 || UsesLdr[1] == nullptr)
+      return 0;
----------------
rafauler wrote:
> I guess you meant
Yes, strange that I've skipped this, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118088/new/

https://reviews.llvm.org/D118088