[PATCH] D120689: [lld][WebAssembly] Improve error reporting for bad ar archive members

Tue Mar 1 11:36:30 PST 2022

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lld/test/wasm/bad-archive-member.s:1
+# REQUIRES: x86
+
----------------
sbc100 wrote:
> dschuff wrote:
> > Why does this need x86? It's a little odd that we are building an x86 object and then linking with wasm-ld?
> Because that is the precise error condition we want to check for here.   We need to create a llvm-ar archive with a valid index, but whose objects are no valid under wasm.
oh right, yeah makes sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120689/new/

https://reviews.llvm.org/D120689