[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

Tue Mar 1 11:29:49 PST 2022

fmayer marked 2 inline comments as done.
fmayer added inline comments.

================
Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9
+// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \
+// RUN:     -fsanitize=hwaddress -mllvm -print-before=hwasan %s 2>&1 | \
 // RUN:     FileCheck %s -check-prefix=LIFETIME
----------------
eugenis wrote:
> fmayer wrote:
> > eugenis wrote:
> > > You can use -Xclang -disable-llvm-passes instead.
> > Isn't what is currently there closer to what we actually want to test: that the hwasan pass has access to lifetimes?
> I don't have a strong opinion on this, but it is common to exclude llvm passes from clang tests because that makes them brittle. Integration tests generally belong in compiler-rt, but there are some in clang, too.
That makes sense. Updated all tests to use disable-llvm-passes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120437/new/

https://reviews.llvm.org/D120437