[PATCH] D109584: [VP] Implementing expansion pass for VP load and store.

Lorenzo Albano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 11:07:05 PST 2022


loralb updated this revision to Diff 412168.
loralb added a comment.

Changelog:

- Address comments

N.B.: the `IsUnmasked == true` path in `expandPredicationInMemoryIntrinsic()` is not reachable, as also shown by the tests. How should this be handled in the code? Do we still handle this case or we add something like `assert(!isAllTrueMask(MaskParam))` instead of defining the `IsUnmasked` boloean?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109584/new/

https://reviews.llvm.org/D109584

Files:
  llvm/lib/CodeGen/ExpandVectorPredication.cpp
  llvm/test/CodeGen/Generic/expand-vp-load-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109584.412168.patch
Type: text/x-patch
Size: 7646 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220301/e7c2e703/attachment-0001.bin>


More information about the llvm-commits mailing list